feat(Pagination): add disabled flag for whole component #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://patternfly-react-pr-2586.surge.sh |
Am I missing a class? |
kmcfaul
force-pushed
the
pagination-disabled
branch
from
0e8bb9e
to
1a0f09e
Compare
kmcfaul
force-pushed
the
pagination-disabled
branch
from
1a0f09e
to
7f67e2a
Compare
tlabaj
requested changes
Aug 1, 2019
karelhala
previously approved these changes
Aug 6, 2019
kmcfaul
force-pushed
the
pagination-disabled
branch
from
b079f62
to
44bec10
Compare
jschuler
reviewed
Aug 7, 2019
| parentRef = null, | ||
| toggleTemplate: ToggleTemplate = '', | ||
| }:OptionsToggleProps ) => { | ||
| return ( | ||
| <div className={css(styles.optionsMenuToggle, getModifier(styles, 'plain'), getModifier(styles, 'text'))} > | ||
| <div className={css(styles.optionsMenuToggle, isDisabled && getModifier(styles, 'disabled'), getModifier(styles, 'plain'), getModifier(styles, 'text'))} > |
There was a problem hiding this comment.
nit: it generally makes more sense to use getModifier if a variable prop can be matched to the style object. In this case i would change these to styles.disabled, styles.plain, etc..
There was a problem hiding this comment.
Ah I thought that was just how we retrieved modifier styles. I can change it to styles.modifiers.disabled and so on.
jschuler
reviewed
Aug 7, 2019
| import React from 'react'; | ||
| import { Pagination, PaginationVariant } from '@patternfly/react-core'; | ||
|
|
||
| class PaginationTop extends React.Component { |
There was a problem hiding this comment.
nit: class name should be PaginationDisabled. Doesn't affect the rendering but shows up in the sample code
jschuler
approved these changes
Aug 8, 2019
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Adds 'isDisabled' flag to disable the whole pagination component.
See issue: #2315